Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add failing test for #64 #65

Merged
merged 2 commits into from
Jun 25, 2017
Merged

chore: add failing test for #64 #65

merged 2 commits into from
Jun 25, 2017

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Jun 11, 2017

I've tracked the issue @isaacs is running into to this change in Babylon.

There's one other ignore related issue I'd like to also add a regression test for, at which point I'd think downgrading babylon might be a good temporary fix.

@bcoe bcoe requested a review from isaacs June 11, 2017 19:32
@coveralls
Copy link

coveralls commented Jun 11, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-40.3%) to 48.221% when pulling 328c896 on 64-fix into 9859636 on master.

@coveralls
Copy link

coveralls commented Jun 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 88.5% when pulling 3eddcef on 64-fix into 9859636 on master.

@bcoe bcoe merged commit 7f94fe8 into master Jun 25, 2017
@bcoe bcoe deleted the 64-fix branch June 25, 2017 18:21
@bcoe bcoe mentioned this pull request Jul 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacs isaacs Awaiting requested review from isaacs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcoe @coveralls