-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: nyc instrument
and --exclude-node-modules
#1039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you note that when input
is a directory all files/folders in it are copied (except .git/
).
4367ec4
to
fad6c6a
Compare
nyc instrument
nyc instrument
and --exclude-node-modules
5 similar comments
Adds basic usage and key limitations
4e0309d
to
7a11521
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good to me 👍 thanks for putting in this work @AndrewFinlay.
One comment, I think we might be at a point (similar to where we hit with yargs a while ago) that we want to refactor the documentation into a few markdown files, see:
https://github.com/yargs/yargs/blob/master/docs/api.md
Not a blocker for this work though, just a thought for the future 👍
Lists basic usage, with a key limitation that the input dir must equal or be a sub-dir of cwd.
I'll probably make a few changes tomorrow, so suggestions are welcome.