Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a feature which allows us to bust the cache when breaking changes are introduced #394

Merged
merged 3 commits into from
Sep 15, 2016

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Sep 15, 2016

when we make potentially breaking changes to the cache, e.g.,

istanbuljs-archived-repos/istanbul-lib-instrument#22

we should increment the cache version, forcing an invalidation so that folks don't see issues like #392

@timoxley
Copy link

I have a feeling this CACHE_VERSION should be automatically derived from package versions.

Cost of accidentally not bumping this version, due to forgetting or not realising it broke, is high.
Cost of nyc having to rebuild the cache after each update is low.

i.e. better to be safe and take a few extra seconds once every update than to potentially introduce fatal & hard to diagnose bugs.

@bcoe bcoe merged commit b7a413a into master Sep 15, 2016
@bcoe bcoe deleted the bust-cache branch September 15, 2016 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants