-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make shims location configurable through environment #49
Comments
@isaacs Sorry to bother you, I've hit this issue again, have you any thoughts on this particular matter? |
i've run into a similar issue with a constrained environment. In my case, the process is running inside a docker container and the user does not actually exist inside the container, but does exist on the host. The call to 'os-homedir' results in
Would be great if these files could be written to a temp directory that is writable by all instead of relying on the user's home directory to exist. Or like the OP suggested, be able to somehow configure the location via an environment variable. |
Thanks a lot! I wasn't sure that proposing directly a PR for this was the right thing to do without any feedback, but if this is the way to go, I'll gladly do it next time. |
Sometimes it's easier to explain what you want in JavaScript than in english. But I'm happy to get suggestions in either language :) The fix was pretty straightforward knowing the codebase, but since this module in particular is a bit of a dense little thicket, I sometimes feel weird asking people to dive into it. |
Following issue #3, #4 fixed it by putting shims directly at the root of the homedir instead of
/tmp
.I have a situation here where the homedir is mounted read-only in a constrained environment for build purposes (I do not want the homedir to be tampered if something in the build process fails).
I am wondering if setting the location of the shims through an environment variable (something like
$SPAWN_WRAP_SHIMS
) is something that you would be willing to consider?The text was updated successfully, but these errors were encountered: