Put temporary shims in $HOME, not $TMP #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /tmp mount is sometimes mounted as noexec, especially on systems where tmp is world-writable. Even though these shims ARE extremely temporary (they are deleted at the end of the process), it makes more sense to put them in $HOME rather than /tmp. Closes #3
|
lgtm |
|
@isaacs awesome, that was fast; I can cut a new release of nyc as soon as this is out the door. |
|
Weird that travis is failing: https://travis-ci.org/isaacs/spawn-wrap/jobs/73139581 It's like it's not being wrapped at all for some reason. |
|
I'd like to work out the travis failures before landing this. Sorry for the delay, everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /tmp mount is sometimes mounted as noexec, especially on systems
where tmp is world-writable.
Even though these shims ARE extremely temporary (they are deleted at the
end of the process), it makes more sense to put them in $HOME rather
than /tmp.
Closes #3
Thanks @rvagg and @bcoe for the spot.