Skip to content

Commit

Permalink
clarify documentation around stringMatch and case-sensitivity (#3305)
Browse files Browse the repository at this point in the history
Signed-off-by: Ian Rudie <[email protected]>
Co-authored-by: Ian Rudie <[email protected]>
  • Loading branch information
istio-testing and ilrudie authored Sep 6, 2024
1 parent 978ac3b commit ba126bb
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 10 deletions.
6 changes: 4 additions & 2 deletions networking/v1/virtual_service_alias.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions networking/v1alpha3/virtual_service.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions networking/v1alpha3/virtual_service.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions networking/v1alpha3/virtual_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1240,8 +1240,8 @@ message RegexRewrite {
string rewrite = 2;
}

// Describes how to match a given string in HTTP headers. Match is
// case-sensitive.
// Describes how to match a given string in HTTP headers. `exact` and `prefix` matching is
// case-sensitive. `regex` matching supports case-insensitive matches.
message StringMatch {
oneof match_type {

Expand All @@ -1252,6 +1252,8 @@ message StringMatch {
string prefix = 2;

// [RE2 style regex-based match](https://github.com/google/re2/wiki/Syntax).
//
// Example: `(?i)^aaa$` can be used to case-insensitive match a string consisting of three a's.
string regex = 3;
}
}
Expand Down
6 changes: 4 additions & 2 deletions networking/v1beta1/virtual_service_alias.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ba126bb

Please sign in to comment.