This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
remove dynamic rest mapper from openshift. #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
googlebot
added
the
cla: yes
istio-testing
added
size/XS
howardjohn
approved these changes
Jan 10, 2020
morvencao
force-pushed
the
br_remove_drm_from_openshift
branch
from
9d4014f
to
e44d41d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: istio/istio#17761
The upstream issue kubernetes-sigs/controller-runtime#321 has been fixed in kubernetes-sigs/controller-runtime#554
The fix has been included in
sigs.k8s.io/controller-runtime v0.4.0Local tests show that istio CRs can be created successfully in the reconcile loop.