Skip to content

Commit

Permalink
jobs: put unit tests on dedicate node (#3885)
Browse files Browse the repository at this point in the history
These jobs used to take like 5 minutes and now take 15, using max CPU
the entire time. I am worried they steal CPU from other jobs.

I have some ideas to optimize it, but for now see how it goes to isolate
them.
  • Loading branch information
howardjohn authored Feb 26, 2022
1 parent fca9e8d commit d28ae63
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 15 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 4 additions & 6 deletions prow/cluster/jobs/istio/istio/istio.istio.master.gen.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions prow/config/jobs/istio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ image: gcr.io/istio-testing/build-tools:master-2022-02-11T17-43-07
jobs:
- name: unit-tests
command: [entrypoint, make, -e, "T=-v -count=1", build, racetest, binaries-test]
resources: dedicated

- name: release-test
service_account_name: prowjob-advanced-sa
Expand All @@ -22,13 +23,13 @@ jobs:
types: [presubmit]
modifiers: [presubmit_optional, presubmit_skipped]
command: [entrypoint, make, benchtest]
resources: benchmark
resources: dedicated

- name: benchmark-report
service_account_name: prowjob-advanced-sa
types: [postsubmit]
command: [entrypoint, make, benchtest, report-benchtest]
resources: benchmark
resources: dedicated

- name: integ-cni
types: [presubmit]
Expand Down Expand Up @@ -420,7 +421,7 @@ resources_presets:
limits:
memory: "24Gi"
# Give 15 CPUs which will put us on a dedicated node, for consistency
benchmark:
dedicated:
requests:
memory: "8Gi"
cpu: "15000m"
Expand Down

0 comments on commit d28ae63

Please sign in to comment.