Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the project to python 3.10 #267

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Conversation

borisjota
Copy link

Upgrade the project to python 3.10

@borisjota borisjota changed the title Update Python version. Upgrade the project to python 3.10 Sep 7, 2023
@madisonb
Copy link
Collaborator

madisonb commented Sep 8, 2023

@borisjota Thank you for this! I'm going to ping the team to review this. A couple of questions from me:

  1. Why define a new decode_dict() when we still have Scrapy's to_dict() method?
  2. I see CircleCI has blocked the test pipeline from running, can you confirm for me that all the tests pass in your local environment?
  3. Why only upgrade to Scrapy 2.6.2 and not 2.10?

Thanks again for your contribution 😄

@borisjota
Copy link
Author

Hello @madisonb

  1. I define a new decode_dict() because byte data exist in the headers and these are not serializers.

  2. I check the CircleCI and their is a build error because i deny access to the push repository in Docker Hup.

  3. ok, update scrapy library to 2.10.0. 😄

greetings.

@BeamoINT
Copy link

Have you tried out Scrapy with these new changes, I did and it seems that the imports are not compatible with Python 3.10. I get this error when running this command.

root@crawler:~/scrapy-cluster/crawler# scrapy runspider crawling/spiders/link_spider.py
Usage

scrapy runspider [options] <spider_file>
runspider: error: Unable to load 'crawling/spiders/link_spider.py': attempted relative import with no known parent package

@borisjota
Copy link
Author

Have you tried out Scrapy with these new changes, I did and it seems that the imports are not compatible with Python 3.10. I get this error when running this command.

root@crawler:~/scrapy-cluster/crawler# scrapy runspider crawling/spiders/link_spider.py

Usage
scrapy runspider [options] <spider_file> runspider: error: Unable to load 'crawling/spiders/link_spider.py': attempted relative import with no known parent package

run the spider with command: scrapy crawl link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants