CMake: Fix warnings #113
Merged
CMake: Fix warnings #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xoviat, sorry, I just did a rebase of the commits. I'll fix this |
|
Not a problem. Don't touch it for now because I want to see the results of the Travis build. |
ghost
|
@isuruf Is there any reason why this fix would not work? It's significantly simpler than the other fix. |
isuruf
previously approved these changes
Jan 1, 2018
|
Note: issue filed at https://gitlab.kitware.com/cmake/cmake/issues/17606 |
The CMake Ninja generator requires the "use" statement to declare dependnecies rather than the "use, instrinsic" statement. Since we're bootsrapping, the "intrinsic" makes no functional difference and leads to race conditions.
|
Works for me locally on linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relies on Ninja's builtin module detection, which failed before because the module directory was previously the same.
Closes gh-114.