-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: Fix warnings #113
CMake: Fix warnings #113
Conversation
@xoviat, sorry, I just did a rebase of the commits. I'll fix this |
Not a problem. Don't touch it for now because I want to see the results of the Travis build. |
@isuruf Is there any reason why this fix would not work? It's significantly simpler than the other fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Can you move the sources iso_c_bid.F95
etc to back to where it was to reduce the diff?
Note: issue filed at https://gitlab.kitware.com/cmake/cmake/issues/17606 |
The CMake Ninja generator requires the "use" statement to declare dependnecies rather than the "use, instrinsic" statement. Since we're bootsrapping, the "intrinsic" makes no functional difference and leads to race conditions.
Works for me locally on linux |
This PR relies on Ninja's builtin module detection, which failed before because the module directory was previously the same.
Closes gh-114.