Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Renovate for Helm Charts #44

Open
hupling opened this issue Sep 19, 2024 · 4 comments
Open

Add Renovate for Helm Charts #44

hupling opened this issue Sep 19, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@hupling
Copy link
Contributor

hupling commented Sep 19, 2024

Hi @eidottermihi ,
baust du den Renovate Bot noch in dein Helm ein? Also wenn wir das Refarch Apigateway dann als Helm Dependency einbinden ist das noch sinnvoll. Der @devtobi meinte dafür muss irgendwie ein zusätzliches Plugin verwendet werden . https://docs.renovatebot.com/presets-customManagers/

@eidottermihi
Copy link
Member

I'm open for contributions, as long as Renovate PRs are then able to automatically bump the chart version (that's currently the reason why helm is disabled in the renovate config).

@eidottermihi eidottermihi removed their assignment Sep 19, 2024
@eidottermihi eidottermihi added the enhancement New feature or request label Sep 19, 2024
@devtobi
Copy link
Member

devtobi commented Sep 19, 2024

I'm open for contributions, as long as Renovate PRs are then able to automatically bump the chart version (that's currently the reason why helm is disabled in the renovate config).

That's what I saw as well when checking the behaviour of the preset. Thats why I'd suggest to either:

  1. leave Renovate out and do Helm chart bumps manually,
  2. add custom GitHub actions logic that runs after a PR by Renovate was created and automatically bumps helm chart version or
  3. Let Renovate create the PR for the bump of the image version and add another manual commit to bump the helm chart version

@eidottermihi @hupling Which would you prefer? Which do you think is less error-prone?

@eidottermihi
Copy link
Member

  1. leave Renovate out and do Helm chart bumps manually,

thats the current situation ;)

  1. add custom GitHub actions logic that runs after a PR by Renovate was created and automatically bumps helm chart version

No clue if this is doable & not prone for errors

  1. Let Renovate create the PR for the bump of the image version and add another manual commit to bump the helm chart version

I'm open for this one, as long as the "manual commit" is then done by the affected chart maintainers. After adding CODEOWNERS I think this would trigger Review requests from the chart maintainers.

@eidottermihi
Copy link
Member

eidottermihi commented Sep 19, 2024

best solution would be that this becomes a feature of Renovate, currently an open feature request: renovatebot/renovate#4728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants