Use go:embed instead of go-bindata #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ph0tonic looks good to me, thanks! Tests are failing though, not sure why but it looks like a bug of some sort in the GitHub environment. Maybe it's because we are using an old version of I'm going to try and bump those to see if something changes. |
bfabio
added a commit
to bfabio/publiccode-parser-go
that referenced
this pull request
Feb 18, 2023
Co-authored-by: Fabio Bonelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #134
I needed to create an
embed.gofile inside the data folder asembeddoes not allow to access parent folders which is an issue to loadipa_codes.txtfrom thevalidatorfolder.