Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI againt for Ruby 3.3 #366

Merged
merged 3 commits into from
Dec 28, 2023
Merged

CI againt for Ruby 3.3 #366

merged 3 commits into from
Dec 28, 2023

Conversation

sue445
Copy link
Member

@sue445 sue445 commented Dec 26, 2023

No description provided.

@sue445 sue445 marked this pull request as ready for review December 26, 2023 15:31
@sue445 sue445 marked this pull request as draft December 26, 2023 15:33
@unasuke unasuke self-requested a review December 26, 2023 16:14
@sue445 sue445 force-pushed the ruby3.3 branch 9 times, most recently from 4f33d18 to fcd3bc3 Compare December 28, 2023 11:06
@sue445
Fixed bundler installing at ruby 2.7
a600277 
details

```
Installing Bundler
  Using latest Bundler for ruby-2.7.8 because the default Bundler gem is too old for that Ruby version
  Ruby 2.6-2.7 only works with Bundler 2.4
  /opt/hostedtoolcache/Ruby/2.7.8/x64/bin/gem install bundler -v ~> 2.4.0
  ERROR:  While executing gem ... (Zlib::BufError)
      buffer error
  Took   0.78 seconds
```

c.f. https://github.com/itamae-kitchen/itamae/actions/runs/7343647181/job/19997130475

Perhaps this is following issue
https://bugs.ruby-lang.org/issues/18058

Therefore, `RUBYOPT` was set only at testing to avoid this issue
@sue445 sue445 marked this pull request as ready for review December 28, 2023 11:22
@sue445
Copy link
Member Author

sue445 commented Dec 28, 2023

@unasuke I have finished working on this PR. Please review me 🙏

unasuke
unasuke approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@unasuke unasuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@sue445 sue445 merged commit 978a19b into master Dec 28, 2023
55 checks passed
@sue445 sue445 deleted the ruby3.3 branch December 28, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unasuke unasuke unasuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sue445 @unasuke