Skip to content

Commit

Permalink
FEAT-modin-project#2013: Apply suggestions from code review
Browse files Browse the repository at this point in the history
Signed-off-by: Itamar Turner-Trauring <[email protected]>

Co-authored-by: Devin Petersohn <[email protected]>
  • Loading branch information
itamarst and devin-petersohn committed Nov 30, 2020
1 parent 22bdfe8 commit 69c1031
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions modin/pandas/general.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ def merge_asof(
raise ValueError(
"can not merge DataFrame with instance of type {}".format(type(right))
)

ErrorMessage.default_to_pandas("`merge_asof`")

# As of Pandas 1.2 these should raise an error; before that it did
Expand Down Expand Up @@ -236,7 +235,7 @@ def merge_asof(
raise ValueError("Can't have both 'by' and 'left_by' or 'right_by'")
left_by = right_by = by

# List of columsn case should have been handled by direct Pandas fallback
# List of columns case should have been handled by direct Pandas fallback
# earlier:
assert isinstance(left_by, (str, type(None)))
assert isinstance(right_by, (str, type(None)))
Expand Down Expand Up @@ -290,7 +289,7 @@ def merge_asof(
# 5. Clean up to match Pandas output:
if left_on is not None and right_index:
result.insert(
list(result.columns).index(left_on + suffixes[0]),
result.columns.get_indexer_for(left_on + suffixes[0])[0],
left_on,
result[left_on + suffixes[0]],
)
Expand Down

0 comments on commit 69c1031

Please sign in to comment.