Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug permission redirect - logs out users #22

Open
ci opened this issue Jul 26, 2017 · 3 comments
Open

Bug permission redirect - logs out users #22

ci opened this issue Jul 26, 2017 · 3 comments

Comments

@ci
Copy link

ci commented Jul 26, 2017

More like a minor bug, cand un user acceseaza orice zona fara permisiuni, este logged out direct. Fiindca authorization_required din app/controllers/concerns/login_concern.rb face redirect la login_path cu notice, functia de login din app/controllers/static_controller.rb apeleaza logout_user first.

Asta daca nu e intended pentru moment? Cred ca o functionalitate default ar fi sa afiseze notice-ul si o posibilitate de go back / go to the homepage in loc sa delogheze userul de fiecare data.
@cezarneaga
Copy link
Collaborator

Ai timp sa trimiti un PR? :)

@ci
Copy link
Author

ci commented Jul 27, 2017

Da, incerc sa trimit un PR pana maine-seara. 😄

@cezarneaga
Copy link
Collaborator

cezarneaga commented Jul 27, 2017 via email

ci pushed a commit to ci/volunt-app that referenced this issue Jul 27, 2017
Create a permission_error page for permission related messages
0a24965 
Related to issue itccsro#22, instead of logging of the users anytime
there is a permission issue, now the user will be redirected
to a permission_error page that does not log him off.

If the user was not logged in in the first place, the behavior
is not changed, the user will be redirected to the login page
with a relevant message instead.
@ci ci mentioned this issue Jul 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cezarneaga @ci