HTTP Grafana #1562
Closed
HTTP Grafana #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Cha
force-pushed
the
http-grpc-grafana
branch
from
7d40b1d
to
2749b4a
Compare
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Alan-Cha
force-pushed
the
http-grpc-grafana
branch
from
b7b705d
to
70c9201
Compare
Closed
kalantar
requested changes
Jul 27, 2023
charts/iter8/values.yaml
Outdated
Comment on lines
12
to
15
| abnmetrics: | ||
| endpoint: iter8-abn:50051 | ||
|
|
||
| ### resources are the resource limits for the pods |
There was a problem hiding this comment.
No need to add this since we moved to Grafana.
driver/kubedriver_test.go
Outdated
Comment on lines
70
to
72
| err := os.Setenv(base.MetricsServerURL, "http://iter8.default:8080") | ||
| assert.NoError(t, err) | ||
|
|
There was a problem hiding this comment.
Not clear that this is needed.
base/experiment.go
Outdated
Comment on lines
40
to
48
| Name string | ||
|
|
||
| // Namespace is the namespace the experiment was deployed in | ||
| Namespace string | ||
| } | ||
|
|
||
| // Experiment struct containing spec and result | ||
| type Experiment struct { | ||
| Metadata ExperimentMetadata |
base/collect_http.go
Outdated
| // getFortioResults collects Fortio run results | ||
| // func (t *collectHTTPTask) getFortioResults() (*fhttp.HTTPRunnerResults, error) { | ||
| // key is the metric prefix | ||
| func (t *collectHTTPTask) getFortioResults() (map[string]*fhttp.HTTPRunnerResults, error) { | ||
| // key is the endpoint | ||
| func (t *collectHTTPTask) getFortioResults() (map[string]fhttp.HTTPRunnerResults, error) { |
There was a problem hiding this comment.
since we are attempting to keep the old functionality, I think it better to leave the data structure the same.
base/collect_http.go
Outdated
Comment on lines
386
to
388
| // TODO: warmup option | ||
| // // ignore results if warmup | ||
| // if t.With.Warmup != nil && *t.With.Warmup { |
metrics/server.go
Outdated
| } | ||
|
|
||
| // httpEndpointPanel is the data needed to produce a single panel for | ||
| type httpEndpointPanel struct { |
Signed-off-by: Alan Cha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.