Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo CD + Istio Gitops tutorial #739

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Conversation

huang195
Copy link
Member

@huang195 huang195 commented Jun 7, 2021

@sriumcp @kalantar @fabolive here's a draft of the GitOps tutorial. One caveat is this PR needs to be merged to the master branch of this repo for all the references/links to work properly.

The intention of this PR is to provide an initial point of view on how one would use Iter8 in a GitOps scenario, and it's specific for Argo CD + Istio. There are quite a few things that could be improved, e.g., using metrics collector instead of fortio, using a real CI pipeline tool instead of runCI.sh to simulate one, etc. These will be done in a follow up tutorial - to explore Iter8 in a full blown CI/CD pipeline, specifically using Openshift Pipeline and Openshift GitOps. In the process, we will figure out what we need to do to get Iter8 v2 to work in an Openshift cluster.

@huang195
Copy link
Member Author

huang195 commented Jun 7, 2021

Opening this in favor of #737 due to messed up commit history.

@huang195
Copy link
Member Author

huang195 commented Jun 8, 2021

  • Cleaned up trailing white spaces
  • Removed unused bookinfo-iter8 namespace
  • Squashed commits

@huang195 huang195 requested review from kalantar and sriumcp June 8, 2021 13:11
@huang195
Copy link
Member Author

huang195 commented Jun 8, 2021

@kalantar @sriumcp what's up with the failing build? I see other merged PRs are also failing checks...

@kalantar
Copy link
Member

kalantar commented Jun 8, 2021

@kalantar @sriumcp what's up with the failing build? I see other merged PRs are also failing checks...

Github was/may still be affected by the fastly outage this morning.

@sriumcp
Copy link
Member

sriumcp commented Jun 8, 2021

Re: failing build, it is due to a breaking change in mkdocs.

Part of the reason why my PR is big is because I pushed a fix for this (among other things :)

@kalantar
Copy link
Member

kalantar commented Jun 8, 2021

Part of the reason why my PR is big is because I pushed a fix for this (among other things :)

I great smaller PR that would have enabled others more quickly :)

@huang195
Copy link
Member Author

huang195 commented Jun 8, 2021

Part of the reason why my PR is big is because I pushed a fix for this (among other things :)

If you could push the fix as a separate PR, that will help.

OTOH, If you have suggestions about making this GitOps PR smaller, please let me know. At the moment, this PR includes all the resource files in samples/gitops as well as the tutorial doc in mkdoc/tutorials/gitops. They need to be in sync to make the review possible. I don't know if it's possible to break them into separate PRs for them to still make sense.

mkdocs/docs/tutorials/gitops/argocd.md Outdated Show resolved Hide resolved
mkdocs/docs/tutorials/gitops/argocd.md Outdated Show resolved Hide resolved
mkdocs/docs/tutorials/gitops/argocd.md Outdated Show resolved Hide resolved
Copy link
Member

@sriumcp sriumcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments.

mkdocs/docs/tutorials/gitops/argocd.md Outdated Show resolved Hide resolved
mkdocs/docs/tutorials/gitops/argocd.md Outdated Show resolved Hide resolved
@huang195
Copy link
Member Author

huang195 commented Jun 9, 2021

@sriumcp @kalantar thanks for the feedbacks. I'll make the suggested changes soon

sriumcp
sriumcp previously approved these changes Jun 14, 2021
Copy link
Member

@sriumcp sriumcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@sriumcp sriumcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sriumcp sriumcp merged commit 116bb09 into iter8-tools:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants