Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install and doc changes needed to introduce builtin metrics #750

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

sriumcp
Copy link
Member

@sriumcp sriumcp commented Jun 8, 2021

Signed-off-by: Srinivasan Parthasarathy [email protected]

Fixes #684

@sriumcp sriumcp requested review from kalantar and huang195 June 8, 2021 18:32
Signed-off-by: Srinivasan Parthasarathy <[email protected]>
Copy link
Member

@kalantar kalantar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor issue identified.

mkdocs/docs/reference/tasks/metrics.md Show resolved Hide resolved
@sriumcp sriumcp requested a review from kalantar June 8, 2021 19:13
Copy link
Member

@huang195 huang195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sriumcp sriumcp merged commit 0377ecd into iter8-tools:master Jun 8, 2021
@sriumcp sriumcp deleted the builtinmetrics branch June 24, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Built-in load generator and metrics collection
3 participants