Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iter8-in-docker-in-tekton #772

Merged
merged 2 commits into from
Jun 10, 2021
Merged

iter8-in-docker-in-tekton #772

merged 2 commits into from
Jun 10, 2021

Conversation

sriumcp
Copy link
Member

@sriumcp sriumcp commented Jun 10, 2021

Signed-off-by: Srinivasan Parthasarathy [email protected]

Fixes #721

The Tekton task is modeled after https://github.com/tektoncd/catalog/tree/main/task/kind/0.1

Signed-off-by: Srinivasan Parthasarathy <[email protected]>
@sriumcp sriumcp self-assigned this Jun 10, 2021
Signed-off-by: Srinivasan Parthasarathy <[email protected]>
Copy link
Member

@sushmarchandran sushmarchandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kalantar
Copy link
Member

Why not do this work on https://github.com/tektoncd/catalog ?

@sriumcp
Copy link
Member Author

sriumcp commented Jun 10, 2021

Yes @kalantar This definitely should end up there eventually. This is an initial attempt to get a sample / use-case working with this feature.

@sriumcp sriumcp merged commit 2675b7d into iter8-tools:master Jun 10, 2021
@sriumcp sriumcp deleted the tkninstall branch June 24, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Wrap Iter8 Docker image within a Tekton task
3 participants