Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add --unshallow #957

Merged
merged 6 commits into from
Apr 13, 2022
Merged

ci: add --unshallow #957

merged 6 commits into from
Apr 13, 2022

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Apr 13, 2022 •
edited
Loading

  • useful cross-CI substitute for GHA checkout.with.fetch-depth: 0
  • probably shouldn't be the default due to
    • not needed in all cases (only needed if full history is required, e.g. some dvc exp run cases)
    • performance hit in large repos

Original idea by @pmrowla

/CC @dberenbaum @alex000kim

@casperdcl casperdcl self-assigned this Apr 13, 2022
@casperdcl casperdcl temporarily deployed to internal April 13, 2022 06:21 Inactive
@casperdcl casperdcl mentioned this pull request Apr 13, 2022
Closed
@casperdcl casperdcl requested a review from a team April 13, 2022 06:24
@casperdcl casperdcl added enhancement New feature or request cml-ci Subcommand labels Apr 13, 2022
@casperdcl casperdcl temporarily deployed to internal April 13, 2022 06:28 Inactive
@pmrowla pmrowla mentioned this pull request Apr 13, 2022
Closed
0x2b3bfa0
0x2b3bfa0 reviewed Apr 13, 2022
View reviewed changes
src/cml.js Outdated Show resolved Hide resolved
@casperdcl casperdcl temporarily deployed to internal April 13, 2022 06:31 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 13, 2022 06:38 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 13, 2022 06:40 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 13, 2022 06:41 Inactive
@0x2b3bfa0
Use --is-shallow-repository
4271c63 
Simplify conditionals
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 13, 2022 06:43 Inactive
@casperdcl casperdcl mentioned this pull request Apr 13, 2022
Merged
@0x2b3bfa0
Copy link
Member

@casperdcl, please take a look to 4271c63 jusr in case I have “pushed too much”

casperdcl
casperdcl commented Apr 13, 2022
View reviewed changes
src/cml.js Outdated Show resolved Hide resolved
@0x2b3bfa0 @casperdcl
Apply suggestions from code review
53fced2 
Co-authored-by: Casper da Costa-Luis <[email protected]>
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 13, 2022 06:51 Inactive
0x2b3bfa0
0x2b3bfa0 previously approved these changes Apr 13, 2022
View reviewed changes
@casperdcl casperdcl temporarily deployed to internal April 13, 2022 06:53 Inactive
@casperdcl casperdcl enabled auto-merge (squash) April 13, 2022 06:55
pmrowla
pmrowla reviewed Apr 13, 2022
View reviewed changes
src/cml.js Show resolved Hide resolved
@casperdcl casperdcl merged commit 40240bb into master Apr 13, 2022
@casperdcl casperdcl deleted the ci-unshallow branch April 13, 2022 07:05
@casperdcl casperdcl mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrowla pmrowla pmrowla left review comments

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

Assignees

@casperdcl casperdcl

@0x2b3bfa0 0x2b3bfa0

Labels
cml-ci Subcommand enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@casperdcl @0x2b3bfa0 @pmrowla