Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cruft: remove copy_without_render #11

Merged
merged 1 commit into from
Sep 19, 2022
Merged

cruft: remove copy_without_render #11

merged 1 commit into from
Sep 19, 2022

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Sep 19, 2022 •
edited
Loading

@dtrifiro
Copy link
Contributor Author

Apparently there are some dependency resolution issues, a dvc version pre 2.27.0 is installed, which doesn't include the testing extra. Looking into it.

@dtrifiro
Copy link
Contributor Author

I think this is due to dvc-http being pinned to 2.19.0 in the dvc repo: one cannot pip install .[tests] and dvc because the latter requires dvc-http==2.19.0, thus we end up installing dvc==2.18.0 which is the first available version with no dvc-http dependency.

Bumping its version here and in dvc should fix the issue, although I think we'll need to fix this issue properly, as it impacts all plugins. c.c. @efiop

@efiop efiop merged commit 0bcfc85 into main Sep 19, 2022
@dtrifiro dtrifiro deleted the remove-copy-without-render branch September 20, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtrifiro @efiop