Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a note on dvc metrics diff --targets with revisions usage #1573

Merged
merged 8 commits into from
Jul 17, 2020

Conversation

imhardikj
Copy link
Contributor

As per suggestion by @jorgeorpinel in #1549 (comment)

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost. What about plots diff though, probably same deal? Thanks @imhardikj

Comment on lines 54 to 56
Without `--`, this statement will show an error as argument parser confuses
`revisions` as arguments for `--targets` option. Alternatively, you can also
run above statement as:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just avoid this sentence and change "may" for "must" or "should" in the previous one, please. Also, "the" is missing again 😞

Suggested change
Without `--`, this statement will show an error as argument parser confuses
`revisions` as arguments for `--targets` option. Alternatively, you can also
run above statement as:
Alternatively, you can also run the above statement as:

Same for plots diff, tnx

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @imhardikj

@jorgeorpinel jorgeorpinel merged commit 21502f2 into iterative:master Jul 17, 2020
@imhardikj imhardikj deleted the mdiff branch July 18, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants