-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a note on dvc metrics diff --targets with revisions usage #1573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost. What about plots diff
though, probably same deal? Thanks @imhardikj
Without `--`, this statement will show an error as argument parser confuses | ||
`revisions` as arguments for `--targets` option. Alternatively, you can also | ||
run above statement as: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just avoid this sentence and change "may" for "must" or "should" in the previous one, please. Also, "the" is missing again 😞
Without `--`, this statement will show an error as argument parser confuses | |
`revisions` as arguments for `--targets` option. Alternatively, you can also | |
run above statement as: | |
Alternatively, you can also run the above statement as: |
Same for plots diff, tnx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @imhardikj
As per suggestion by @jorgeorpinel in #1549 (comment)