Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guide: begin How To section #1705

Merged
merged 28 commits into from
Sep 28, 2020
Merged

guide: begin How To section #1705

merged 28 commits into from
Sep 28, 2020

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Aug 20, 2020 •
edited
Loading

Extracted from #1581

JUST A DRAFT TO START THIS GOING — Please don't review yet.

Ref: #899 and https://documentation.divio.com/how-to-guides/#how-to

AFTER MERGE

@shcheklein shcheklein temporarily deployed to dvc-landing-guide-how-t-o2pslj August 20, 2020 16:45 Inactive
@jorgeorpinel
Copy link
Contributor Author

@imhardikj please solve merge conflicts and continue this (:

@shcheklein shcheklein temporarily deployed to dvc-landing-guide-how-t-o2pslj August 21, 2020 14:24 Inactive
@shcheklein shcheklein had a problem deploying to dvc-landing-guide-how-t-o2pslj August 21, 2020 16:30 Failure
@shcheklein shcheklein had a problem deploying to dvc-landing-guide-how-t-o2pslj August 22, 2020 20:39 Failure
@shcheklein shcheklein temporarily deployed to dvc-landing-guide-how-t-o2pslj August 24, 2020 13:27 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-guide-how-t-o2pslj August 24, 2020 16:44 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-guide-how-t-o2pslj August 25, 2020 22:05 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Aug 25, 2020
Merged
9 tasks
@shcheklein shcheklein temporarily deployed to dvc-landing-guide-how-t-o2pslj August 27, 2020 19:55 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-guide-how-t-o2pslj August 27, 2020 22:50 Inactive
jorgeorpinel
jorgeorpinel commented Sep 23, 2020
View reviewed changes
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK this is almost ready! Please address the latest round of comments and we'll merge this, @imhardikj.

We can leave #1705 (comment) for a follow up PR.

@jorgeorpinel
Copy link
Contributor Author

p.s. @shcheklein can you please approve this PR? I started it so I can't.

@jorgeorpinel jorgeorpinel mentioned this pull request Sep 23, 2020
Closed
jorgeorpinel
jorgeorpinel commented Sep 28, 2020
View reviewed changes
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here! @shcheklein can you please approve the PR. I can't because I started it...

@jorgeorpinel
Copy link
Contributor Author

Actually @imhardikj please try to approve it, maybe you also can? Probably not but I'm not sure.

@jorgeorpinel
Copy link
Contributor Author

Failed test is OK (new page). Merging 🎉

@jorgeorpinel jorgeorpinel merged commit 7acceb4 into master Sep 28, 2020
@jorgeorpinel
Copy link
Contributor Author

This doc can be expanded for stage outputs.

Please do a separate PR with a proposal for that when you have some spare time @imhardikj, thanks.

@jorgeorpinel
Copy link
Contributor Author

Looks like we failed to update the old /doc/user-guide/updating-tracked-files links to the new location, /doc/user-guide/how-to/updated-tracked-files

But I remember reviewing the checks before merging... In fact they didn't fail 🤔 https://app.circleci.com/pipelines/github/iterative/dvc.org/5905/workflows/79da4dc3-e28f-4321-810c-89b0fb2afac1/jobs/5961 cc @shcheklein

Fixing in #1823

@shcheklein
Copy link
Member

shcheklein commented Sep 29, 2020 •
edited by jorgeorpinel
Loading

We don't use CircleCI to check links anymore. We migrated to the GH actions. I guess you should have merged the latest master?

@jorgeorpinel
Copy link
Contributor Author

Makes sense. Well, it's fixed now 🙂

jorgeorpinel
jorgeorpinel commented Oct 6, 2020
View reviewed changes
content/docs/sidebar.json
Comment on lines -101 to +105
"updating-tracked-files",
{
"label": "How To",
"slug": "how-to",
"source": false,
"children": ["undo-adding-data", "update-tracked-files"]
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Oct 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So! It seems this URL transition was not smooth at all. Just leaving this here for future reference and it's not a major page that used to have thousands of visits but we went from over 100 to around 20 total after this 😢 (for now).

A redirect would probably have helped after all (cc @shcheklein) because some the traffic for this page came from old GitHub comments that had a direct link, which after this change started producing 404s (I fixed those comments now).

image

Cc thanks for the tip on GA usage for this @jeremydesroches (in #1823 (comment))

@jorgeorpinel jorgeorpinel mentioned this pull request Oct 7, 2020
Merged
@jeremydesroches jeremydesroches mentioned this pull request Oct 8, 2020
Merged
@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imhardikj imhardikj imhardikj approved these changes

Assignees

@imhardikj imhardikj

Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

how to: "undo" 'dvc add' + other "how to undo mistakes" recipes
3 participants
@jorgeorpinel @imhardikj @shcheklein