Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import: add '--file' option #1816

Merged
merged 2 commits into from
Sep 27, 2020
Merged

import: add '--file' option #1816

merged 2 commits into from
Sep 27, 2020

Conversation

DiPaolo
Copy link
Contributor

@DiPaolo DiPaolo commented Sep 27, 2020

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

This is documentation update for iterative/dvc#4622.

Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DiPaolo
Can you please try to let us know when iterative/dvc/pull/4622 is merged, to do the same here after that?
Thanks

@jorgeorpinel jorgeorpinel added the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Sep 27, 2020
@efiop
Copy link
Contributor

efiop commented Sep 27, 2020

@jorgeorpinel iterative/dvc/pull/4622 is merged 🙂

@@ -86,6 +88,11 @@ repo at `url`) are not supported.
current working directory). Directories specified in the path must already
exist, otherwise this command will fail.

- `--file <filename>` - specify a path and/or file name for the `.dvc` file
created by this command (e.g. `--file stages/stage.dvc`). This overrides the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to avoid using stage in the import context (for the future cc @jorgeorpinel )

Copy link
Contributor

@jorgeorpinel jorgeorpinel Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. We have a pending check box about this in the #608 epic. Also rel=#1366

@shcheklein shcheklein merged commit 3a80a8c into iterative:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌛ status: wait-core-merge Waiting for related product PR merge/release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants