metrics(plots): regular udpates & terminology #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorgeorpinel
commented
Oct 7, 2020
•
jorgeorpinel
commented
- Improve metrics/plots explanations
- "metric file" -> "metrics file" per term: call metrics "metrics" and plots "plots" #1442 and a checkbox in term: misc. clarifications #608
jorgeorpinel
commented
Oct 7, 2020
shcheklein
reviewed
Oct 7, 2020
jorgeorpinel
commented
Oct 7, 2020
jorgeorpinel
commented
Oct 7, 2020
jorgeorpinel
commented
Oct 7, 2020
jorgeorpinel
commented
Oct 7, 2020
jorgeorpinel
commented
Oct 7, 2020
shcheklein
approved these changes
Oct 11, 2020
jorgeorpinel
commented
Oct 11, 2020
There was a problem hiding this comment.
- A few of these would imply a change in the core repo too:
UPDATE: Updated in iterative/dvc/pull/4699.
Comment on lines
11
to
14
| positional arguments: | ||
| targets Limit command scope to these metric files. | ||
| Using -R, directories to search metric files | ||
| targets Limit command scope to these metrics files. | ||
| Using -R, directories to search metrics files | ||
| in can also be given. |
Comment on lines
14
to
+15
| positional arguments: | ||
| target Metric file to set properties to | ||
| target Metrics file to set properties to |
Comment on lines
14
to
16
| positional arguments: | ||
| targets Metric files to visualize. | ||
| targets Metrics files to visualize. | ||
| Shows all plots by default. |
2 tasks
efiop
added a commit
to iterative/dvc
that referenced
this pull request
Oct 12, 2020
* api: update to latest definitions to match iterative/dvc.org/pull/908 * Update dvc/api.py * metrics show: update -h output to match docs per iterative/dvc.org@2c34521 * api: update docstrings to match iterative/dvc.org/pull/908 * api: refactor DVC repo check in get_url, and document it * dvc: cosmetic edits as I explored exceptions that api functions may raise * api: copy default info to read() docstring from open() per #3426 (review) * api: improve open() docstring for clarity and add example per #3426 (review) * api: remove unnecessary info from get_url docstring per #3426 (comment) * api: produces->generated in open() docstring * api: simplify open docstring per #3426 (comment) * term: "metrics" plural in output messages iterative/dvc.org#1848 (review) * typo Co-authored-by: Ruslan Kuprieiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.