Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: DVC Experiments Overview #2909

Merged
merged 50 commits into from
Dec 13, 2021
Merged

guide: DVC Experiments Overview #2909

merged 50 commits into from
Dec 13, 2021

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Oct 9, 2021

Originally extracted from #2654 (comment)

OTHER possible goals (may follow-up after this PR if needed):

@shcheklein shcheklein temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse October 9, 2021 00:42 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Oct 9, 2021
2 tasks
@jorgeorpinel jorgeorpinel marked this pull request as ready for review October 10, 2021 01:54
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse October 10, 2021 01:54 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse October 10, 2021 01:58 Inactive
Comment on lines 81 to 68
### Organization patterns
### Organization Patterns

DVC takes care of arranging `dvc exp` experiments and the data
<abbr>cache</abbr> under the hood. But when it comes to full-blown persistent
experiments, it's up to you to decide how to organize them in your project.
These are the main alternatives:
It's up to you to decide how to organize completed experiments. These are the
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Oct 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From #2654 (review)

should it be somewhere inside? (not on the index page)?

@shcheklein maybe, let's decide... But not in scope for this PR probably?

@jorgeorpinel jorgeorpinel self-assigned this Oct 10, 2021
@jorgeorpinel jorgeorpinel changed the title guide: add DVC Experiments page guide: add DVC Experiments page (?) Oct 10, 2021
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse October 11, 2021 19:27 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse November 1, 2021 23:46 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse November 1, 2021 23:54 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse November 2, 2021 00:54 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse November 2, 2021 00:54 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse November 2, 2021 01:11 Inactive
Copy link
Collaborator

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor comments 🙏 . If it's vital to get it merge now, let me know and I can approve, but I think one more iteration might be useful.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse December 7, 2021 23:14 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse December 8, 2021 01:33 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse December 8, 2021 02:06 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Dec 10, 2021

@shcheklein several possible follow-ups here (see PR description) but do you think this is mergeable? Thanks

UPDATE: I removed a bunch of unrelated changes that somehow got to this PR (probably nested PR), moving to #3080

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse December 10, 2021 17:46 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse December 10, 2021 17:50 Inactive
jorgeorpinel added a commit that referenced this pull request Dec 10, 2021
jorgeorpinel added a commit that referenced this pull request Dec 10, 2021
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-exp-dvc-exps-pa-qhfdse December 10, 2021 17:53 Inactive
@jorgeorpinel
Copy link
Contributor Author

I know there are still questions around this but they're larger than just about the index and overview page so I'm merging this much. Should be followed upon in #2911. Thanks

@jorgeorpinel jorgeorpinel merged commit 359e05f into master Dec 13, 2021
@jorgeorpinel jorgeorpinel deleted the exp/dvc-exps-page branch December 13, 2021 22:02
jorgeorpinel added a commit that referenced this pull request Dec 23, 2021
* ref: bring changes from #2909

* guide: bring changes from #2909

* exp: pull some changes from #2908

* ref: better explain exp apply behavior explicitly
rel. #3080 (comment)

* ref: exp apply destroys any canges
per #3080 (comment)

* ref: clarify that exp branch makes 1+ commits in the exp branch
rel. #3080 (comment)

* ref: link exp apply -> exp branch
per #3080 (comment)

* ref: clarify (again) what applies does specifically
per #3080 (review)

* ref: document intended apply behavior on conflicting changes
per #3080 (review)
iesahin pushed a commit that referenced this pull request Apr 11, 2022
* guide: add DVC Experiments page and links +
some copy edits

* guide: remove checkpoint related changes

* guide: remove `dvc experiments` long cmd autolinks
per #2901

* guide: move run-cache section back to Exp Mgmt index bottom
per #2909 (review)

* guide: Exp Mgmt/ DVC Exps -> Exps Overview
per #2909 (review)

* guide: clear separation between Exp Mgmt index and Overview page
rel #2909 (comment)

* guide: single guide for Persisting Exps content and
fix links

* guide: begin extracting Exp details from Running to Overview
rel #2909 (comment)

* guide: make ToC entry for Run Cache section
rel #2909 (comment)

* Update content/docs/user-guide/experiment-management/index.md

Co-authored-by: Ivan Shcheklein <[email protected]>

* [NESTED] guide: Exp implementation details, naming into Overview (#3006)

* guide: bring exp implementation details and naming from ref.
per #2909 (review)

* guide: copy edits to exp naming info.

* guide: emphasize dvc exps are not part of Git tree in overview
rel #2909 (review)

* guide: ID->name in dvc exps overview
per #2909 (review)

* guide: ID->name in other exp guides
rel #2909 (review)

* guide: Visualize->Review in exp/overview/basic-workflow
per #2909 (review)

* guide: don't say "cleans the slate" in exp/overview/basic-workflow
per #2909 (review)

* giude: soften params description in exps index
per #2909 (review)

* guide: generalize dvc exps basic workflow

* guide: Properties section in DVC Exps overview page

* guide: exp init section in Exp Overview page

* guide: clarify dvc exp implementation

* guide: expand on Exp Overview motivation
per #2909 (comment)

* guide: direct language in Exp Overview/ workflow intro
per #2909 (comment)

* guide: mention metrics in exp init intro (Exp Overview)
per #2909 (comment)

* guide: intro exp init before giving specific examples of what it does
per #2909 (comment)

* guide: hint forach stages for hybrid exp org pattern
rel. #2909 (comment)

* guide: exp mgmt index copy edits

* guide: mention label-based exp organization
rel. https://docs.google.com/presentation/d/1C_owNoC72GvrpyMGlonHEYJ9I2rl2SLHkZQDMx0eT7A/edit#slide=id.gcb78e52e40_0_635

* guide: hide exp naming section in overview page and
other details
per #2909 (comment)
et al.

* guide: mention `exp init -i` in Overview
per #2909 (comment)

* guide: typo fix
per #2909 (comment)

* ref: exp apply copy edits
per #2909 (review)

* ref: mention init before exp init
per #2909 (review)

* guide: correct info aboug exp init in Exp Overview
per pending comments in #2909 (review)

* ref: link from exp init to corresponding guide

* guide: make exp intro more concrete
per #2909 (comment)

* guide: rewrite exp init section of Exps Overview page
per #2909 (review)

* ref: roll back unrelated ref changes (moved to ref/exp-misc)

* guide: roll back unrelated changes (moved to #3080)

Co-authored-by: Ivan Shcheklein <[email protected]>
iesahin pushed a commit that referenced this pull request Apr 11, 2022
* ref: bring changes from #2909

* guide: bring changes from #2909

* exp: pull some changes from #2908

* ref: better explain exp apply behavior explicitly
rel. #3080 (comment)

* ref: exp apply destroys any canges
per #3080 (comment)

* ref: clarify that exp branch makes 1+ commits in the exp branch
rel. #3080 (comment)

* ref: link exp apply -> exp branch
per #3080 (comment)

* ref: clarify (again) what applies does specifically
per #3080 (review)

* ref: document intended apply behavior on conflicting changes
per #3080 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants