Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start: Reorganize into Trails (Candidate #1, Take #2) #3444

Closed
wants to merge 62 commits into from

Conversation

iesahin
Copy link
Contributor

@iesahin iesahin commented Apr 13, 2022

Due to branching error in #3442, I renewed the PR.

This PR updates the whole Get Started section into a "trail format" we discussed in #2496. It's an example to present the GS section into a less scary way.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's first keep even simpler - two trails, no need to change any content (split into separate section - it looks a bit strange). We can iterate after that if needed.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Apr 19, 2022

Yeah, it was interesting to see all the small pages, but I don't think our engine is currently very conducive to using such short one-pagers -- maybe if we had a better <PREVIOUS, NEXT> navigation UI.

Also it's very hard to review the PR with so many file changes so for a quick proposal just 2 or 3 pages with the existing content in a different order would be better indeed.

I realize it will be pretty long for just 2 trails but let's try it (we can call it candidate #2) and take it from there.

p.s. there's a problem in the formatting of the GS index page.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Apr 19, 2022

it's very hard to review the PR with so many file changes

I guess we can review the deployment. As for the order of sections (focusing on left-side nav), here's my general feedback:

  • A bit too granular, some of these pages can be a single section e.g. Adding Files + Making Changes; or Storing & sharing + Retrieving; or all the import-related ones -- I.e. it's OK to remove some headings if you're making small changes (but no need to do so at first).
  • I like the more practical renaming of some of the nav titles 👍🏼
  • I'm surprised there's no overlap between trails (no repeated sections). I guess that's good?

But also, let's finish #3050 first! So it can be included in this.

@iesahin iesahin mentioned this pull request Apr 20, 2022
2 tasks
@iesahin
Copy link
Contributor Author

iesahin commented Apr 25, 2022

Closing in favor of #3455

@iesahin iesahin closed this Apr 25, 2022
@jorgeorpinel jorgeorpinel deleted the iesahin/gs-reorg-2 branch July 29, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants