Let sidebar uppercase more than dvc in labels made from slugs
#3602
Conversation
* Let sidebar uppercase more than `dvc` in labels made from slugs
| @@ -23,12 +23,22 @@ | |||
| const { titleCase } = require('title-case') | |||
| const sidebar = require('../../../sidebar') | |||
|
|
|||
| const uppercaseKeywords = ['dvc', 'cml', 'api', 'ml'] | |||
There was a problem hiding this comment.
@jorgeorpinel, these are the keywords that will be uppercased. Does the list look good?
There was a problem hiding this comment.
List is now ['dvc', 'cml', 'api', 'mlem', 'ml', 'ldb'] :)
| @@ -620,7 +620,6 @@ | |||
| "slug": "dvclive-with-dvc" | |||
| }, | |||
| { | |||
| "label": "ML Frameworks", | |||
There was a problem hiding this comment.
Since the sidebar code automatically uppercases ml and api, these two labels can be taken off.
Gatsby Cloud Build Reportdvc.org 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 2m PerformanceLighthouse report
|
plugins/gatsby-theme-iterative-docs/src/utils/shared/sidebar.js
Outdated
Show resolved
Hide resolved
plugins/gatsby-theme-iterative-docs/src/utils/shared/sidebar.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Good stuff, @julieg18 - some optimization I think is possible that makes sense + some cleanup (?)
plugins/gatsby-theme-iterative-docs/src/utils/shared/sidebar.js
Outdated
Show resolved
Hide resolved
|
Last Q. There's also the opposite feature i.e. some words are kept lower case, like |
|
The |
|
Ah thanks for the info. Will mention in iterative/gatsby-theme-iterative#17 |
Fixes #3601