-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #657: Reorganize tutorials into their own section. #666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff and long needed first step in reorganizing and consolidating tutorials, @dashohoxha - just minor comments on naming.
Hey did you check this tutorial to try to integrate it? https://medium.com/@fullstackml/aab8162f8e3f |
And do you agree that this PR addresses #564? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please pull origin/master and solve conflicts as well 🙂 (This may simplify the list of files marked as changed in the PR, making it easier to review.)
It seems like a draft, but we can list it if needed. We can also do it after merging this PR.
Yes of course, at least some parts of it.
I have done it once before. I did it again. But the status still shows conflicts and the button "Resolve conflicts" is inaccessible for me (grey). Can you check it, if you have access? @shcheklein We really should try to avoid conflicts because they are more work and trouble than the patch itself. |
It seems to be fixed now. |
…mprehensive tutorial.
👍
Yep, sorry about that. Not merging any refactorings before we merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, @dashohoxha ! Merging this to move forward.
- Let's improve the redirect handler a bit in a separate PR to cover
/doc/tutorial(/.*)?
Per Fix #657: Reorganize tutorials into their own section. #666 (review)
Cool! What about the UPDATE: Actually that link isn't even working right now. It's trying to go to inexistent path |
👍 changed it to |
That's deep. |
Fix #657