Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more GAPI privacy policy updates #987

Merged
merged 6 commits into from
Feb 11, 2020
Merged

more GAPI privacy policy updates #987

merged 6 commits into from
Feb 11, 2020

Conversation

jorgeorpinel
Copy link
Contributor

No description provided.

@shcheklein shcheklein temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 10, 2020 22:01 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Feb 10, 2020
Merged
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 10, 2020 22:26 Inactive
@jorgeorpinel

This comment has been minimized.

Sign in to view
@shcheklein

This comment has been minimized.

Sign in to view
@jorgeorpinel
Copy link
Contributor Author

I agree. But it's also not a user guide. It wold be nice to be able to not have it in the sidebar I guess, just linked from some place... Maybe work on #731 ?

BTW, should re remove the current link from the footer then? And put it in the remote add and remote modify cmd refs.

@shcheklein
Copy link
Member

shcheklein commented Feb 10, 2020 •
edited by jorgeorpinel
Loading

@jorgeorpinel don't see it as a big deal right now, let's get back to this discussion when we start the User Guide restructuring.

footer link was requested by the Google verification team.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 11, 2020 00:03 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 11, 2020 01:25 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Feb 11, 2020 •
edited
Loading

don't see it as a big deal right now, let's get back to this discussion when we start the User Guide restructuring

OK, noted in #144 (comment)

footer link was requested by the Google verification team

OK, can I rename it "Google APIs Privacy Policy" just for correctness? Typically a link like this on the footer is a general privacy policy for data collection of DVC itself, not specific to the integration in this case. But we don't really collect any personal data, so its a bit misleading.

jorgeorpinel added a commit that referenced this pull request Feb 11, 2020
@jorgeorpinel
remote: rename GAPI privacy policy
107930e 
per #987 (comment)
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 11, 2020 01:35 Inactive
@iterative iterative deleted a comment from shcheklein Feb 11, 2020
@shcheklein
Copy link
Member

OK, can I rename it "Google APIs Privacy Policy" just for correctness?

Let's not mess with this right now. We can think how to generalize, improve this, etc later, way later.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 11, 2020 01:41 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 11, 2020 01:50 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 11, 2020 01:53 Inactive
shcheklein
shcheklein approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge it, not wait for more unrelated changes 🙏

@jorgeorpinel jorgeorpinel changed the title Regular updates (Feb 10+) more GAPI privacy policy updates Feb 11, 2020
@jorgeorpinel jorgeorpinel marked this pull request as ready for review February 11, 2020 02:07
@jorgeorpinel
Copy link
Contributor Author

OK, I renamed the PR, merging!

@jorgeorpinel jorgeorpinel merged commit b4014c0 into master Feb 11, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 16, 2020
Closed
@srishti-nema srishti-nema mentioned this pull request May 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhora maxhora maxhora left review comments

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeorpinel @shcheklein @maxhora