params: fix bug when collecting multiple params (#3615)

iterative · Apr 9, 2020 · cdef709 · cdef709
1 parent c1ac6bb
commit cdef709
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/dvc/repo/params/show.py b/dvc/repo/params/show.py
@@ -20,9 +20,9 @@ def _collect_params(repo):
                 configs[dep.path_info] = copy.copy(dep)
                 continue
 
-            existing = set(configs[dep.path_info].params)
-            new = set(dep.params)
-            configs[dep.path_info].params = list(existing.update(new))
+            params = set(configs[dep.path_info].params)
+            params.update(set(dep.params))
+            configs[dep.path_info].params = list(params)
 
     return configs.values()
 

diff --git a/tests/func/params/test_show.py b/tests/func/params/test_show.py
@@ -14,6 +14,15 @@ def test_show(tmp_dir, dvc):
     assert dvc.params.show() == {"": {"params.yaml": {"foo": "bar"}}}
 
 
+def test_show_multiple(tmp_dir, dvc):
+    tmp_dir.gen("params.yaml", "foo: bar\nbaz: qux\n")
+    dvc.run(fname="foo.dvc", params=["foo"])
+    dvc.run(fname="baz.dvc", params=["baz"])
+    assert dvc.params.show() == {
+        "": {"params.yaml": {"foo": "bar", "baz": "qux"}}
+    }
+
+
 def test_show_list(tmp_dir, dvc):
     tmp_dir.gen("params.yaml", "foo:\n- bar\n- baz\n")
     dvc.run(params=["foo"])