Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI progress #3060

Closed
3 tasks
casperdcl opened this issue Jan 5, 2020 · 5 comments
Closed
3 tasks

UI progress #3060

casperdcl opened this issue Jan 5, 2020 · 5 comments
Labels
enhancement Enhances DVC performance improvement over resource / time consuming tasks refactoring Factoring and re-factoring research ui user interface / interaction

Comments

@casperdcl
Copy link
Contributor

casperdcl commented Jan 5, 2020

  • add progress to other uses of stage.dump
  • profile repo.check_modified_graph(), stage.save(), stage.dump() etc to find out what other functions are slow, perhaps add progress for them too
    • md5sums only take about 10% of the total time. There must be other more time consuming functions
  • make sure that we show HINT message to enable cache optimization properly when copy is taking too long already
  • continues add: cleanup and improve output #2699
  • continues UI progress cleanup #2846
@casperdcl casperdcl added enhancement Enhances DVC refactoring Factoring and re-factoring ui user interface / interaction performance improvement over resource / time consuming tasks research labels Jan 5, 2020
@casperdcl casperdcl mentioned this issue Jan 5, 2020
7 tasks
@casperdcl
Copy link
Contributor Author

make sure that we show HINT message to enable cache optimization properly when copy is taking too long already

@shcheklein is this done already? I seem to recall it may have been mentioned in a different PR.

@shcheklein
Copy link
Member

@casperdcl so, I'm not sure to be honest. It's super important and should be done in a way that is visible when certain thresholds are passed. I don't remember what is current policy even. I would revisit them.

@efiop
Copy link
Contributor

efiop commented Feb 3, 2020

Current policy is per-link, so it only shows a warning if one individual link takes longer than 10 seconds. It doesn't account for like, 2 links of 5 seconds or anything like that. Feels like we could simply lower the threshold to improve the experience, but need to make protected = True by default first.

@shcheklein
Copy link
Member

First thing I would say for this ticket is make sure that it is visible clearly with all these changes to progress bars and whatnot.

@efiop
Copy link
Contributor

efiop commented Oct 8, 2021

Clsoing as stale. Now working on pre-requisites like libifying dvc/objects and creating events, which will then enable proper ui/pbars.

@efiop efiop closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC performance improvement over resource / time consuming tasks refactoring Factoring and re-factoring research ui user interface / interaction
Projects
None yet
Development

No branches or pull requests

3 participants