Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: make progress bars respect --quiet #3316

Merged
merged 5 commits into from
Feb 14, 2020
Merged

ui: make progress bars respect --quiet #3316

merged 5 commits into from
Feb 14, 2020

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Feb 12, 2020 •
edited
Loading

@casperdcl casperdcl added bug Did we break something? enhancement Enhances DVC ui user interface / interaction research labels Feb 12, 2020
@casperdcl casperdcl requested a review from efiop February 12, 2020 23:03
@casperdcl casperdcl self-assigned this Feb 12, 2020
casperdcl
casperdcl commented Feb 12, 2020
View reviewed changes
dvc/lock.py Outdated Show resolved Hide resolved
@casperdcl casperdcl closed this Feb 14, 2020
@casperdcl casperdcl deleted the silent-push branch February 14, 2020 18:56
@casperdcl casperdcl restored the silent-push branch February 14, 2020 19:14
@casperdcl casperdcl reopened this Feb 14, 2020
@casperdcl
Copy link
Contributor Author

casperdcl commented Feb 14, 2020 •
edited
Loading

<comment moved to separate issue #3332>

@casperdcl casperdcl added the refactoring Factoring and re-factoring label Feb 14, 2020
@casperdcl
Copy link
Contributor Author

@efiop I think this is good to merge. I don't think it's worth reverting the no_progress_bar=None changes as I intend removing most of them in a future PR (see #3332).

efiop
efiop reviewed Feb 14, 2020
View reviewed changes
dvc/remote/azure.py Outdated Show resolved Hide resolved
@casperdcl casperdcl mentioned this pull request Feb 14, 2020
Merged
3 tasks
@casperdcl casperdcl requested a review from efiop February 14, 2020 22:04
efiop
efiop approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit 276a2b0 into iterative:master Feb 14, 2020
@casperdcl casperdcl deleted the silent-push branch February 14, 2020 23:25
@weekly-digest weekly-digest bot mentioned this pull request Feb 16, 2020
Closed
@casperdcl casperdcl restored the silent-push branch February 21, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop approved these changes

Assignees

@casperdcl casperdcl

Labels
bug Did we break something? enhancement Enhances DVC refactoring Factoring and re-factoring research ui user interface / interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dvc push -q is not completely quiet, shows file transfer tqdm progress bars
2 participants
@casperdcl @efiop