Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params diff #3528

Closed
dmpetrov opened this issue Mar 25, 2020 · 0 comments
Closed

params diff #3528

dmpetrov opened this issue Mar 25, 2020 · 0 comments
Assignees
Labels
feature request Requesting a new feature p0-critical Critical issue. Needs to be fixed ASAP. product: VSCode Integration with VSCode extension

Comments

@dmpetrov
Copy link
Member

dmpetrov commented Mar 25, 2020

Users need to compare hyperparameters (issue #3393, implementation #3515) changes in different experiments. Something like dvc metrics diff is needed for parameters with the same syntax.

The difference: the delta-value/change-value which is not needed since DVC treats all the parameters as strings.

Examlpe:

$ cat params.yaml
angles:
    - 15
    - 30
    - 40
train:
    lr: 0.0041
    dropout: 0.21

$ dvc params diff
   Path             Param       Old            New
params.yaml   angles      [15, 30, 45]   [15, 30, 40]
params.yaml   train.lr         0.0041          0.0041
params.yaml   train.dropout   0.21              0.225

It should support the same set of args --targets, a_rev, b_rev and --show-json.

A possible addition (nice to have) - ignore not changed parameters (-c/--changes-only can be a good name).

# No lr since it was not changed
$ dvc params diff -c
   Path             Param       Old            New
params.yaml   angles      [15, 30, 45]   [15, 30, 40]
params.yaml   train.dropout   0.21              0.225

ADDED: It needs to take care of the dvc metrics issues that are not closed yet: #3469

@dmpetrov dmpetrov added feature request Requesting a new feature product: VSCode Integration with VSCode extension labels Mar 25, 2020
@efiop efiop added the p0-critical Critical issue. Needs to be fixed ASAP. label Mar 26, 2020
@efiop efiop self-assigned this Mar 26, 2020
efiop added a commit to efiop/dvc that referenced this issue Apr 9, 2020
@efiop efiop closed this as completed in c1ac6bb Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requesting a new feature p0-critical Critical issue. Needs to be fixed ASAP. product: VSCode Integration with VSCode extension
Projects
None yet
Development

No branches or pull requests

2 participants