Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics diff: cryptic error in --no-scm projects [qa] #3605

Closed
jorgeorpinel opened this issue Apr 7, 2020 · 0 comments · Fixed by #3650
Closed

metrics diff: cryptic error in --no-scm projects [qa] #3605

jorgeorpinel opened this issue Apr 7, 2020 · 0 comments · Fixed by #3650
Labels
bug Did we break something? enhancement Enhances DVC p2-medium Medium priority, should be done, but less important ui user interface / interaction

Comments

@jorgeorpinel
Copy link
Contributor 

λ dvc version
DVC version: 0.92.0
Python version: 3.7.5
Platform: Windows-10-10.0.18362-SP0
Binary: True
Package: exe

λ dvc metrics diff
ERROR: unexpected error - 'NoSCM' object has no attribute 'resolve_rev'

Run in a --no-scm DVC project. Compare to dvc diff:

λ dvc diff
ERROR: failed to get diff - only supported for Git repositories
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Apr 7, 2020
@jorgeorpinel jorgeorpinel added enhancement Enhances DVC ui user interface / interaction labels Apr 7, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Apr 7, 2020
@jorgeorpinel jorgeorpinel changed the title metrics diff: cryptic error in --no-scm projects metrics diff: cryptic error in --no-scm projects [qa] Apr 7, 2020
@weekly-digest weekly-digest bot mentioned this issue Apr 12, 2020
Closed
@efiop efiop added bug Did we break something? p3-nice-to-have It should be done this or next sprint p2-medium Medium priority, should be done, but less important and removed p3-nice-to-have It should be done this or next sprint labels Apr 14, 2020
karajan1001 pushed a commit to karajan1001/dvc that referenced this issue Apr 19, 2020
fix iterative#3605
d2e6835
@karajan1001 karajan1001 mentioned this issue Apr 19, 2020
Merged
3 tasks
efiop added a commit that referenced this issue Apr 21, 2020
@karajan1001 @jorgeorpinel @efiop
metrics diff error message in --no-scm projects (#3650)
254cf83 
* fix #3605

* changed exception raise position

* Updated error msg

* message changed

* metrics diff: output edits per
per #3650
and #3650 (review)

* Update tests/func/test_metrics.py

Co-Authored-By: Ruslan Kuprieiev <[email protected]>

* NoSCM now had a default attribute getting method

`NoSCM` Object now raise `NoSCMError` when calling attributes which only in `Git` Object

* Joined lines

Mail change test

* tests: diff: use NoSCMError

Co-authored-by: myname <[email protected]>
Co-authored-by: karajan1001 <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
Co-authored-by: Ruslan Kuprieiev <[email protected]>
Co-authored-by: Ruslan Kuprieiev <[email protected]>
@weekly-digest weekly-digest bot mentioned this issue Apr 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Did we break something? enhancement Enhances DVC p2-medium Medium priority, should be done, but less important ui user interface / interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics diff error message in --no-scm projects karajan1001/dvc
2 participants
@jorgeorpinel @efiop