Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repro: support running stage via it's output's name #3875

Open
skshetry opened this issue May 26, 2020 · 6 comments
Open

repro: support running stage via it's output's name #3875

skshetry opened this issue May 26, 2020 · 6 comments
Assignees
Labels
feature request Requesting a new feature p2-medium Medium priority, should be done, but less important

Comments

@skshetry
Copy link
Member

We should probably accept an output as a target.
It can solve some problems with autocomplete and improve experience. Related #3743 (especially last comments).

$ dvc repro model.pkl

Originally posted by @shcheklein in #3777

@skshetry skshetry added feature request Requesting a new feature discussion requires active participation to reach a conclusion labels May 26, 2020
@efiop
Copy link
Contributor

efiop commented Dec 8, 2020

looks like moving to collect_granular in

targets = self.stage.collect(
, should do the trick.

@efiop efiop added p2-medium Medium priority, should be done, but less important good first issue and removed discussion requires active participation to reach a conclusion labels Dec 8, 2020
@skshetry
Copy link
Member Author

skshetry commented Dec 8, 2020

@efiop, globbing is not possible with collect_granular(). So, either we should use different function based on glob or if we want to make globbing default, we do not support this at all.

@efiop
Copy link
Contributor

efiop commented Dec 8, 2020

@skshetry I didn't mean globbing, just output -> dvcfile mapping.

@Vonski
Copy link

Vonski commented Jan 14, 2021

I can do this one. Could I take it?

@Vonski
Copy link

Vonski commented Feb 11, 2021

For now collect_granular, if provided with glob that matches any out files, returns the same PathInfo for all found stages. This PathInfo is created directly from provided glob. Sometimes filter_info from collect_granular is used further and can end up being passed to methods like path_info.isin_or_eq which do not handle globs. If someone in the future try to add glob=True argument to call of collect_granular in places like for example Repo.used_cache or commit method from dvc/repo/commit.py then it may not work as expected, because returned filter_info is used after that and is built from glob.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Apr 7, 2021

Hi. Should this also apply to status and maybe run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requesting a new feature p2-medium Medium priority, should be done, but less important
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants