-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow skipping certain git revisions/commits in DVC #5066
Comments
Could consider creating a |
Viewer team might find this interesting too CC @Suor |
We simply skip broken commits, not sure this will affect viewer in any way. |
I feel having a |
Might be used to silent errors in viewer too, I guess. And skipping is faster than parsing of cause. |
Some related work was done in #5984 for certain commands to skip bad revisions. Specifying revisions to ignore would still be a nice feature, but I'm lowering the priority for now since it's not in our current roadmap. |
If the
dvc.yaml
files are corrupted in certain revisions,dvc
just fails and there's no way to skip that.@courentin raised #3885 for this and again on #5037 to specifically address this.
For most parts of DVC, it might be okay and we can also teach params/metrics/plots to cope with failures in certain revisions.
But, for other commands such as push/pull/gc, dvc might just fail, even if we skip those failing commits, it'd be better not to skip and ask users to make their intentions clearer to provide stronger "data versioning" requirements.
And, for
gc
, it's even dangerous, and forpush
/pull/
gc`, it might just be confusing.So, coming to my proposal, it'd be better if we could provide a way for users to tell DVC to skip certain commits.
One of the ways would be to provide
--ignore-revs
or similarly named flags inpush/pull/gc
, etc.But, it might not be always easier to use those flags and might be cumbersome especially in CI.
To solve this, we can provide a config (eg:
ignore_revsFile
) where you could provide a file with list of revisions to ignore:The file will always be read from the latest checked out commit.
If the file is cumbersome, we could instead provide a way of adding a list of revs in
.dvc/config
as they are always read from the workspace.The text was updated successfully, but these errors were encountered: