Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics show --all-commits fails on corrupt historic commits #5844

Closed
jheister opened this issue Apr 19, 2021 · 3 comments
Closed

metrics show --all-commits fails on corrupt historic commits #5844

jheister opened this issue Apr 19, 2021 · 3 comments
Assignees
@pared
Labels
A: metrics Related to dvc metrics bug Did we break something?

Comments

@jheister
Copy link

When using metrics show --all-commits we got failures due to a historic commit where a dvc.lock file was committed with merge conflicts in it.

I think it would be best to skip (and log warnings) revisions where a LockfileCorruptedError is thrown.
jheister added a commit to jheister/dvc that referenced this issue Apr 19, 2021
@jheister
metrics: Skip revisions with corrupt dvc.lock files
69db63d 
Fixes iterative#5844
@jheister jheister mentioned this issue Apr 19, 2021
Closed
2 tasks
@dberenbaum
Copy link
Collaborator

Thanks @jheister! I think this is a duplicate of #5525, so I'm closing for now. Hoping to get to it soon. If you think it's a separate issue, feel free to follow up.

@dberenbaum
Copy link
Collaborator

Sorry, missed that you submitted a PR for this! I'll leave open for now then.

@dberenbaum dberenbaum reopened this Apr 19, 2021
@pared pared added the bug Did we break something? label Jul 14, 2021
@pared
Copy link
Contributor

pared commented Jul 19, 2021

Fixed by #5984

@pared pared closed this as completed Jul 19, 2021
@daavoo daavoo added the A: metrics Related to dvc metrics label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pared pared

Labels
A: metrics Related to dvc metrics bug Did we break something?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics: Skip revisions with corrupt dvc.lock files jheister/dvc
4 participants
@jheister @dberenbaum @pared @daavoo