Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: get rid of is_py checks #3021

Merged
merged 2 commits into from Dec 31, 2019
Merged

py3: get rid of is_py checks #3021

merged 2 commits into from Dec 31, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 31, 2019 •
edited by ghost
Loading

Related: #1818

@ghost
Copy link
Author

ghost commented Dec 31, 2019

To ease the review process, I'll create a separate (or maybe several) PR(s) on top of this one to remove the rest of utils.compat

@ghost ghost requested a review from efiop December 31, 2019 00:59
@ghost ghost mentioned this pull request Dec 31, 2019
Merged
efiop
efiop reviewed Dec 31, 2019
View reviewed changes
dvc/istextfile.py Outdated Show resolved Hide resolved
efiop
efiop approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit dd5e058 into iterative:master Dec 31, 2019
@ghost ghost deleted the remove-utils-compat branch December 31, 2019 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@efiop