Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: remove string compat related code #3024

Merged
merged 1 commit into from Dec 31, 2019
Merged

py3: remove string compat related code #3024

merged 1 commit into from Dec 31, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 31, 2019

Related: #1818

@ghost ghost requested a review from efiop December 31, 2019 04:59
efiop
efiop reviewed Dec 31, 2019
View reviewed changes
dvc/cache.py
@@ -54,7 +53,7 @@ def getter(self):

return Remote(self.repo, name=remote)

getter.__name__ = builtin_str(name)
getter.__name__ = str(name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this conversion though?

efiop
efiop reviewed Dec 31, 2019
View reviewed changes
dvc/path_info.py
@@ -54,7 +51,7 @@ def __str__(self):
return relpath(path)

def __repr__(self):
return builtin_str("{}: '{}'").format(type(self).__name__, self)
return str("{}: '{}'").format(type(self).__name__, self)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This str("") has no sense 🙂

efiop
efiop approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit 32ee197 into iterative:master Dec 31, 2019
@ghost ghost deleted the unicode-str branch December 31, 2019 19:02
@ghost
Copy link
Author

ghost commented Dec 31, 2019

thanks for the review, @efiop ! I'll address those comments in the next PR.

@efiop
Copy link
Contributor

efiop commented Jan 1, 2020

@MrOutis Oops, sorry, merged accidentally. 🙁

@ghost ghost mentioned this pull request Jan 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@efiop