Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: use links from os module #3090

Merged
merged 4 commits into from Jan 11, 2020
Merged

py3: use links from os module #3090

merged 4 commits into from Jan 11, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 8, 2020

Related: #1818

efiop
efiop reviewed Jan 9, 2020
View reviewed changes
dvc/system.py Outdated Show resolved Hide resolved
efiop
efiop reviewed Jan 9, 2020
View reviewed changes
dvc/system.py Outdated Show resolved Hide resolved
efiop
efiop reviewed Jan 9, 2020
View reviewed changes
dvc/system.py Show resolved Hide resolved
ghost
ghost commented Jan 10, 2020
View reviewed changes
dvc/system.py Show resolved Hide resolved
ghost
ghost commented Jan 10, 2020
View reviewed changes
dvc/system.py Show resolved Hide resolved
ghost
ghost commented Jan 10, 2020
View reviewed changes
dvc/system.py Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jan 11, 2020

@efiop , only an unrelated test (SSH is_dir) is failing on Travis.

efiop
efiop approved these changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop
Copy link
Contributor

efiop commented Jan 11, 2020

@efiop , only an unrelated test (SSH is_dir) is failing on Travis.

Thanks @MrOutis ! I'm fixing it in #3104 , should be ready soon.

@efiop efiop merged commit 0110358 into iterative:master Jan 11, 2020
@ghost ghost deleted the py3-system branch January 11, 2020 02:31
@weekly-digest weekly-digest bot mentioned this pull request Jan 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@efiop