GDrive: fix freezing on errors by improving granularity of retries #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3593 +/- ##
==========================================
- Coverage 90.96% 90.90% -0.07%
==========================================
Files 143 143
Lines 9232 9236 +4
==========================================
- Hits 8398 8396 -2
- Misses 834 840 +6
Continue to review full report at Codecov.
|
efiop
reviewed
Apr 6, 2020
jorgeorpinel
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Yes, it's fast now. Thanks!
I just still think the error message is unnecessarily long, it could be shorter and just tell you what the problem is without having to decipher 3-4 lines of error messages:
ERROR: failed to upload '.dvc\cache\aa\6ed9e0f26a6eba784aae8267df1951'
to 'gdrive://1sNSAH4rmBqq8S7yUwZCx0wDYvFxVjH_b/aa/6ed9e0f26a6eba784aae8267df1951' -
<HttpError 403 when requesting https://www.googleapis.com/drive/v2/files?
supportsAllDrives=true&alt=json returned "Insufficient permissions for the specified parent.">
ERROR: failed to push data to the cloud - 1 files failed to upload
efiop
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3580
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
β I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. π