Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: use reverse post-order DFS in repro --downstream #3689

Merged
merged 4 commits into from
Apr 28, 2020

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Apr 28, 2020

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Will close #3602.

from original issue:

Looks like the issue is that for --downstream, we are reversing the DAG, and then traversing the reversed graph w/DFS pre-ordered search. In the example case, using pre-ordered search provides no guarantee that step3 is only visited after step2.
...
I think what we should be doing is traversing the reversed graph w/reverse post-ordered search, to ensure that dependencies are run in the correct order.

@pmrowla pmrowla added the bug Did we break something? label Apr 28, 2020
@pmrowla pmrowla self-assigned this Apr 28, 2020
tests/func/test_repro.py Outdated Show resolved Hide resolved
@pmrowla
Copy link
Contributor Author

pmrowla commented Apr 28, 2020

test_pull_git_imports is occasionally failing on travis, but unrelated to this issue (see #3570)

@efiop efiop merged commit 4fdf7ca into iterative:master Apr 28, 2020
@pmrowla pmrowla deleted the 3602-repro-downstream branch April 29, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repro: downstream: reproducing in wrong order
4 participants