cache relpath on stage #4053
Merged
cache relpath on stage #4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
added
enhancement
skshetry
commented
Jun 16, 2020
skshetry
commented
Jun 16, 2020
Comment on lines
222
to
+226
| with folder.chdir(): | ||
| # `Stage` caches `relpath` results, forcing it to reset | ||
| stage1.path = stage1.path | ||
| stage2.path = stage2.path | ||
|
|
There was a problem hiding this comment.
Ugly hack, chdir is now not supported as we cache the relpath. It's fine for CLI use-case, but for API usecases, it sucks.
efiop
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #4052A lot of
relpathcalls were being used bynetworkxindirectly throughStage::__eq__()andStage::__hash__(). They would callrelpathandabspathcalls. This PR caches them.Compare with #4052 with following:
Related #3653
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏