term: replace 'DVC-file' and 'stage file' with correct terms (#3960) #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrowla
suggested changes
Jan 26, 2021
dvc/dvcfile.py
Outdated
| @@ -65,7 +65,7 @@ def is_lock_file(path): | |||
| def check_dvc_filename(path): | |||
| if not is_valid_filename(path): | |||
| raise StageFileBadNameError( | |||
| "bad DVC-file name '{}'. DVC-files should be named " | |||
| "bad DVC file name '{}'. DVC files should be named " | |||
| "'Dvcfile' or have a '.dvc' suffix (e.g. '{}.dvc').".format( | |||
There was a problem hiding this comment.
I think we can get rid of the Dvcfile part of this error message entirely since we are completely dropping single-stage support in 2.0?
There was a problem hiding this comment.
I would leave it as it is for now. Later it can be changed closely to 2.0. Anyway, I'm not so informed about 2.0 specific, so it could be difficultly to me to change the message.
There was a problem hiding this comment.
The current master branch is for 2.0 so it is safe to change it. The message should be something like:
bad DVC file name '{}'. DVC files should be named '{PIPELINE_FILE}' or have a '.dvc' suffix (e.g. '{}.dvc')
pmrowla
suggested changes
Jan 28, 2021
efiop
added
the
awaiting response
|
hey @DiPaolo, any updates on this? |
|
@pmrowla I've pushed an update. |
pmrowla
approved these changes
Feb 5, 2021
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3960
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Documentation on dvc.org was already updated before.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏