exp init: ask for command before paths #6872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for putting this together! I'm fine with whatever you think is best. |
|
Okay, thinking about it more, I am not very sure about this. The command at the start makes more sense given the fact that all of the paths are the effect of it. It might be easier for us to even ask users the follow-up questions. But I still find it a bit confusing as the text jumps a few line after asking for the command. So, I'd say let's go with the command at the first, and we can see what the feedbacks will be from other members, and we can adjust that later. |
skshetry
force-pushed
the
exp-init-command-before-path
branch
from
10bde25
to
2887148
Compare
skshetry
force-pushed
the
exp-init-command-before-path
branch
from
2887148
to
236081b
Compare
dberenbaum
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the ordering of prompts, now it'll ask for command first before showing the workspace tree and prompts for the paths.
This is an RFC PR. I find it a bit confusing as it seems to break the linear flow of the prompts. I have yet another suggestion to move this prompt to the end. cc @dberenbaum @daavoo
Part of #6446.
Before this PR
After this PR
Alternative