Add parent-sha input #257
Merged
Add parent-sha input #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
added
the
A: example-get-started-experiments
daavoo
commented
Sep 26, 2023
| tags: | ||
| - "results/train=pool-segmentation#*" | ||
| - "*" |
There was a problem hiding this comment.
This was dependent on a hardcoded model name and it got broken after the prefix was removed.
It should be okay to trigger on all tags as there is a check below that only tries to deploy if gto parses the tag as assigment (I assume it would not that for unrelated tags)
There was a problem hiding this comment.
Should be okay, but in theory we need to account for repos with multiple models, right? What do you think is best? Should we filter here or parse info from gto below?
dberenbaum
reviewed
Sep 26, 2023
|
|
||
| runner-job: | ||
| needs: deploy-runner | ||
| runs-on: [ self-hosted, cml ] | ||
| environment: cloud | ||
| container: | ||
| image: iterativeai/cml:0-dvc2-base1-gpu | ||
| image: iterativeai/cml:latest-gpu |
dberenbaum
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for https://github.com/iterative/studio/pull/7773 + some fixes