updates vars and secrets in ci #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dberenbaum
commented
Nov 16, 2023
| @@ -109,7 +109,7 @@ jobs: | |||
| - name: Train | |||
| env: | |||
| REPO_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }} | |||
| STUDIO_TOKEN: ${{ secrets.STUDIO_TOKEN }} | |||
| DVC_STUDIO_TOKEN: ${{ secrets.DVC_STUDIO_TOKEN }} | |||
There was a problem hiding this comment.
We were using a mix of STUDIO_TOKEN and DVC_STUDIO_TOKEN before. Now it should consistently use DVC_STUDIO_TOKEN everywhere.
@tibor-mach Minor, but maybe we should use the env var in the deployment example to match here and because it seems a bit more straightforward for the CI case (no real need to configure it globally for one-time use).
dberenbaum
commented
Nov 16, 2023
| @@ -26,6 +26,7 @@ jobs: | |||
| deploy-model: | |||
| needs: parse | |||
| if: "${{ needs.parse.outputs.event == 'assignment' }}" | |||
| environment: cloud | |||
There was a problem hiding this comment.
In #271, we changed the role from AWS_SAGEMAKER_ROLE to AWS_SANDBOX_ROLE and dropped environment: cloud. I'm taking a guess here that the AWS_SAGEMAKER_ROLE exists and has the correct value and was failing because it's only scoped to the cloud environment, but I need @shcheklein to confirm.
shcheklein
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix: