Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy model from MR in GitLab #279

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Deploy model from MR in GitLab #279

merged 2 commits into from
Dec 18, 2023

Conversation

tibor-mach
Copy link
Contributor

Adding a model registry CICD template for GitLab. Needed for this docs PR . For simplicity (to have nothing but that example in the .gitlab-ci.yml file I renamed the old .gitlab-ci.yml...I am wondering whether we need that old one at all. It seems to be used to run experiments via CML, so it is probably not useless, but I would rather put it somewhere else.

In GitLab there apparently cannot be multiple workflow files, so I am not sure how to do this best (to keep the MR example file as simple as possible).

Any ideas about that @mnrozhkov or @dberenbaum ?

@tibor-mach tibor-mach added the A: docs Area: user documentation (related) label Dec 18, 2023
@tibor-mach tibor-mach self-assigned this Dec 18, 2023
@mnrozhkov
Copy link

@tibor-mach thanks! If the old CI config is valid for deployment scenarios, we may keep it in a separate dir like gitlab |
WDYT?

@tibor-mach
Copy link
Contributor Author

@mnrozhkov It looks like it is not just valid, but even necessary for some of the tests to pass :-) But I like your idea, I would instead put the example template in the gitlab folder and give it a descriptive name. People are going to copy-paste it anyway.

Although it would also be good to have a test for its validity. I guess that can be a new issue (for the backlog most likely).

@dberenbaum
Copy link

It looks like it is not just valid, but even necessary for some of the tests to pass

Looks like it is because the new file was named gitlab-ci.yml instead of .gitlab-ci.yml.

@tibor-mach
Copy link
Contributor Author

Looks like it is because the new file was named gitlab-ci.yml instead of .gitlab-ci.yml.
ah, my bad

@dberenbaum
Copy link

Other than that, LGTM to me, thanks @tibor-mach! I'm fine with the idea to move the old workflow to another dir for now.

@tibor-mach
Copy link
Contributor Author

Other than that, LGTM to me, thanks @tibor-mach! I'm fine with the idea to move the old workflow to another dir for now.

I guess it makes sense to do it this way and not the other way around...because if a GitLab user forks the repo, they will be able to use it as-in without having to move or rename any .gitlab-ci.yml files. Unless we refer to the old file somewhere in our get started guides...

@dberenbaum
Copy link

I guess it makes sense to do it this way and not the other way around

Not sure I follow. What are the options?

@tibor-mach
Copy link
Contributor Author

I guess it makes sense to do it this way and not the other way around

Not sure I follow. What are the options?

The other option is to create a directory called (e.g.) gitlab-templates and put the new workflow there. It would actually make sense to put all gitlab files there...kind of like we do with .github/workflows/, except that GitLab does not support that structure (it has some include keywords which kind of replicate this but it makes the syntax somewhat more complicated).

@dberenbaum
Copy link

Okay, so it's about which file to keep in .gitlab-ci.yml, right? Yes, I agree the new one is the better "default" since I don't think we directly reference the old one anywhere in the docs, and the new one is needed for the MR get started workflow.

@tibor-mach tibor-mach merged commit 21712e9 into master Dec 18, 2023
2 checks passed
@tibor-mach tibor-mach deleted the mr-deployment-gitlab branch December 18, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (related)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants