-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy model from MR in GitLab #279
Conversation
@tibor-mach thanks! If the old CI config is valid for deployment scenarios, we may keep it in a separate |
@mnrozhkov It looks like it is not just valid, but even necessary for some of the tests to pass :-) But I like your idea, I would instead put the example template in the Although it would also be good to have a test for its validity. I guess that can be a new issue (for the backlog most likely). |
Looks like it is because the new file was named |
|
Other than that, LGTM to me, thanks @tibor-mach! I'm fine with the idea to move the old workflow to another dir for now. |
I guess it makes sense to do it this way and not the other way around...because if a GitLab user forks the repo, they will be able to use it as-in without having to move or rename any |
Not sure I follow. What are the options? |
The other option is to create a directory called (e.g.) |
Okay, so it's about which file to keep in |
Adding a model registry CICD template for GitLab. Needed for this docs PR . For simplicity (to have nothing but that example in the
.gitlab-ci.yml
file I renamed the old.gitlab-ci.yml
...I am wondering whether we need that old one at all. It seems to be used to run experiments via CML, so it is probably not useless, but I would rather put it somewhere else.In GitLab there apparently cannot be multiple workflow files, so I am not sure how to do this best (to keep the MR example file as simple as possible).
Any ideas about that @mnrozhkov or @dberenbaum ?