experiments: make notebook more like the pipeline #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
reviewed
Jan 6, 2024
example-get-started-experiments/code/notebooks/TrainSegModel.ipynb
Outdated
Show resolved
Hide resolved
|
so, what is the current behavior?
|
dberenbaum
commented
Jan 6, 2024
Comment on lines
+235
to
+236
| " with Live(\"results/evaluate\") as live:\n", | ||
| " live.summary[\"dice_multi\"] = evaluate(learn)" |
There was a problem hiding this comment.
Experiment still gets saved here. dvc_exp_save=False above is only needed to avoid having two experiments saved for each run since there are two different live instances for train and eval.
dberenbaum
commented
Jan 6, 2024
| "from PIL import Image" | ||
| "from PIL import Image\n", | ||
| "\n", | ||
| "os.chdir(\"..\")\n", |
There was a problem hiding this comment.
By changing to the root dir at the start, we end up with similar behavior to the pipeline and the notebook writes to dvc.yaml there.
|
Studio project to see how it looks: https://studio.iterative.ai/user/dberenbaum/projects/exp-notebook-0nufj91gh8 |
shcheklein
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the notebook and pipeline code more similar by modifying the notebook code to use the same paths and otherwise reusing the code from the pipeline. The changes from the notebook to the pipeline were probably more realistic than making them both so similar, but it makes the repo harder to understand and maintain.